A single post is somehow creating multiple topics with no replies

angus · January 27, 2025, 12:07pm

Ok, I finally had the time to recreate this case in a spec.

github.com/angusmcleod/discourse-activity-pub

spec/integration/integration_cases_spec.rb

057e1ce98

RSpec.describe "integration cases" do
  def read_json(case_name, file_name)
    JSON.parse(
      File.open(
        File.join(File.expand_path("../..", __dir__), "spec", "fixtures", "integration", case_name, "#{file_name}.json"),
      ).read
    ).with_indifferent_access
  end

  describe "#case 1" do
    let!(:actor) { Fabricate(:discourse_activity_pub_actor_group) }
    let!(:remote_actor) do
      json = read_json("case_1", "group_actor")
      Fabricate(:discourse_activity_pub_actor_group, ap_id: json[:id], local: false)
    end
    let!(:follow) do
      Fabricate(
        :discourse_activity_pub_follow,
        follower: actor,
        followed: remote_actor,

This file has been truncated. show original

The reason this happened is because:

Discourse was unable to resolve a Conversation type for context.
The error thrown in 1 was too nested to properly roll back the relevant transactions.

This will address the immediate issue

@devnull I haven’t been keeping up with the latest on context / collections etc. Could you briefly explain the thinking behind using “Conversation” instead of “OrderedCollection” in context. Is it meant to be a type of collection…or?